Chronological Thread 

< Chronological >      < Thread >

---

On Thu, Apr 05, 2001 at 11:48:47AM +0200, Andreas Jungmaier wrote:
> > > > As that should not happen very often I don't think it
> > > > is a performance problem.
> >
> > Really?
> > For each UDP and SCTP packet received, the sockunion is converted to a
> > string, (see adl_sockunion2str() calls in adaptation.c:dispatch_event())
> > which would have to be eventually reparsed by the callback.
> > This is unnecessary overhead.
>
> Well, I have not only looked at your patches but also read
> your comments :-)
> In the current version of the code I have changed at least the
> SCTP thing - it does not do the conversion twice now.
>
> > > I prefer having predefined structs.
> >
> > So do I. IMHO passing string-encoded addresses, especially in callbacks,
> > isn't a good idea.
>
> And so do I, of course. That was why we initially passed sockunions.
> I did not like the idea of strings, either at first - but Siemens
> gets what Siemens wants :-)

Well believe it or not, my SCTP related work is also mandated by Siemens!
And on the embedded system where they use the library (a 50mhz MPC860 board)
repetitive string manipulations are a non-negligible waste of CPU resources.

> And there were surprisingly few comments about the API, when we
> discussed it before - well except for some of the Siemens developers,
> notably Wolfgang Schrüfer who had some very good remarks.

Unfortunately I was too busy at the time to follow and participate in
those discussions, but they surely lead to many good improvements.

However the usage of strings when processing packets leaves to be desired..

Gruss
Marc

---

• [SCTP-Discussion] Is the timer_list initialised?, Coene Lode, 04/02/2001
  • <Possible follow-up(s)>
  • RE: [SCTP-Discussion] Is the timer_list initialised?, Coene Lode, 04/04/2001
    • Re: [SCTP-Discussion] Is the timer_list initialised?, Andreas Jungmaier, 04/04/2001
  • RE: [SCTP-Discussion] Is the timer_list initialised?, Coene Lode, 04/04/2001
    • Re: [SCTP-Discussion] Is the timer_list initialised?, Marc Boucher, 04/05/2001
      • Re(2): [SCTP-Discussion] Is the timer_list initialised?, Michael Tüxen, 04/05/2001
        • Re: Re(2): [SCTP-Discussion] Is the timer_list initialised?, Marc Boucher, 04/05/2001
      • Re: [SCTP-Discussion] Is the timer_list initialised?, Andreas Jungmaier, 04/05/2001
        • Re: [SCTP-Discussion] Is the timer_list initialised?, Marc Boucher, 04/05/2001
          • [SCTP-Discussion] Strings vs. Sockunion, Andreas Jungmaier, 04/05/2001
  • RE: [SCTP-Discussion] Is the timer_list initialised?, Wagner, Joel, 04/05/2001
    • Re: [SCTP-Discussion] Is the timer_list initialised?, Marc Boucher, 04/05/2001
  • RE: [SCTP-Discussion] Is the timer_list initialised?, Wagner, Joel, 04/05/2001

---

Archive powered by MHonArc 2.6.19+.