Chronological Thread 

< Chronological >      < Thread >

---

> > > - ain't it better to work with the sockunion struct instead of the
> > > char/byte array. At least the compiler get something more to do than
> > > generating assember code. It can warn you if you did
> > provide the wrong
> > > parameter to your function. (I like strong type checking anyway by a
> > > compiler)
> >
> > Well, we had some lengthy conversation with Wolfgang Schrüfer
> > and he felt it was better to have an sctp.h that did not include
> > any OS specific stuff (indeed it is plain C now).
> > Internally we use the struct sockunion - so there is one conversion
> > involved inside the library from string to struct sockunion
> > per new SCTP instance (plus another one in your application
> > maybe). As that should not happen very often I don't think it
> > is a performance problem.

Really?
For each UDP and SCTP packet received, the sockunion is converted to a string,
(see adl_sockunion2str() calls in adaptation.c:dispatch_event())
which would have to be eventually reparsed by the callback.
This is unnecessary overhead.

> I prefer having predefined structs.

So do I. IMHO passing string-encoded addresses, especially in callbacks,
isn't a good idea.

Marc

> Need the converted IP address anyway caus it can be included in the SUA msg.
> Doesn't really matter to me,works (and change was confined to a single file

> pffft...)

---

• [SCTP-Discussion] Is the timer_list initialised?, Coene Lode, 04/02/2001
  • <Possible follow-up(s)>
  • RE: [SCTP-Discussion] Is the timer_list initialised?, Coene Lode, 04/04/2001
    • Re: [SCTP-Discussion] Is the timer_list initialised?, Andreas Jungmaier, 04/04/2001
  • RE: [SCTP-Discussion] Is the timer_list initialised?, Coene Lode, 04/04/2001
    • Re: [SCTP-Discussion] Is the timer_list initialised?, Marc Boucher, 04/05/2001
      • Re(2): [SCTP-Discussion] Is the timer_list initialised?, Michael Tüxen, 04/05/2001
        • Re: Re(2): [SCTP-Discussion] Is the timer_list initialised?, Marc Boucher, 04/05/2001
      • Re: [SCTP-Discussion] Is the timer_list initialised?, Andreas Jungmaier, 04/05/2001
        • Re: [SCTP-Discussion] Is the timer_list initialised?, Marc Boucher, 04/05/2001
          • [SCTP-Discussion] Strings vs. Sockunion, Andreas Jungmaier, 04/05/2001
  • RE: [SCTP-Discussion] Is the timer_list initialised?, Wagner, Joel, 04/05/2001
    • Re: [SCTP-Discussion] Is the timer_list initialised?, Marc Boucher, 04/05/2001
  • RE: [SCTP-Discussion] Is the timer_list initialised?, Wagner, Joel, 04/05/2001

---

Archive powered by MHonArc 2.6.19+.